🤖 perf: fix shimmer animation frame drops during compaction #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
fix-shimmer-compaction-frame-drops
branch
2 times, most recently
from
8345f5d to
b84a3d5
Compare
Use CSS transform animation (compositor thread) instead of background-position (main thread repaint) to avoid frame drops when compaction summary is streaming. The key insight: CSS transform animations run on the compositor thread, completely off the main thread. This is important during streaming when the main thread is busy with React updates and text parsing. Changes: - CompactionBackground: Use translateX transform instead of background-position - Add shimmer-slide keyframes to globals.css - Add StreamingCompaction story to visualize the effect - Add createCompactionRequestMessage helper to mockFactory _Generated with mux_
ammar-agent
force-pushed
the
fix-shimmer-compaction-frame-drops
branch
from
b84a3d5 to
09c03d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CSS transform animation (compositor thread) instead of background-position (main thread repaint) to prevent frame drops when compaction summary is streaming.
Changes
translateXtransform instead ofbackground-positionshimmer-slidekeyframes to globals.css (runs on compositor thread)StreamingCompactionstory to visualize the effectWhy this fixes frame drops
CSS
transformanimations run on the GPU compositor thread, completely off the main JavaScript thread. This matters during streaming when the main thread is busy with React updates and text parsing. In contrast,background-positiontriggers repaints on every frame.Generated with
mux